Project

General

Profile

Bug #3186

Number of Hot potatoes or tests limit

Added by Olivier CORRE over 8 years ago. Updated about 8 years ago.

Status:
Bug resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
31/03/2011
Due date:
% Done:

100%

Estimated time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

I can't seem to be be able to have more than 50 activities inside the test tool (/main/exercice/exercice.php). Is it a bug?

Associated revisions

Revision 9eed61f5 (diff)
Added by Julio Montoya about 8 years ago

Some fixes when listing hot potatoes see #3186

History

#1

Updated by Julio Montoya over 8 years ago

I cant reproduce the error in 1.8.8 I added hotspots and simple questions

#2

Updated by Olivier CORRE over 8 years ago

Is it an issue with Hot Potatoes exercices then? Adding a new (Chamilo) test when there are already 50 exercices works fine+ but it removes one HP.+
Try with HP if you can.

#3

Updated by Julio Montoya over 8 years ago

  • Status changed from New to Assigned
  • Assignee set to Julio Montoya
  • % Done changed from 0 to 10

Thanks Olivier I just reproduced the error, I'm going to fix it ...

#4

Updated by Julio Montoya over 8 years ago

  • Status changed from Assigned to Needs more info
  • Assignee deleted (Julio Montoya)
  • % Done changed from 10 to 80

This bug hides other exercise problem when using hot potatoes, the problem is that the hot potatoes are not registered in the quiz table, anyways I fix the bug but I'm open other task for this issue #3190

http://code.google.com/p/chamilo/source/detail?r=962fa1c211800202b8e4a71954eb70a3ac77b044&repo=classic

#5

Updated by Olivier CORRE over 8 years ago

Can i apply this as it is or does this other task need to be completed first? I might need a quick fix for this one.

#6

Updated by Julio Montoya over 8 years ago

This fix resolves the problem, the other task is to change the current behaviour of the hotpotatoes+exercises that implies other changes in the database so not also a priority for now.

#7

Updated by Olivier CORRE over 8 years ago

is there a way to apply this to 1.8.7.1 without breaking anything?

#8

Updated by Julio Montoya over 8 years ago

Well, I changed a lot the code in the exercise tool (mostly trying to clean the code), so both versions are very different, I don't suggest to force a fix, you will risk to break the tool.

#9

Updated by Olivier CORRE over 8 years ago

yeah, i noticed that a lot was changed. well, im in need of a solution for this one on 1.8.7.1.
will increasing the value of $limitExPage = 50; allow me to bypass this bug for the moment ?

#10

Updated by Yannick Warnier over 8 years ago

I'm adding André Boivin to the discussion as HotPotatoes are his specialty. André, if you get a chance to check the patch from Julio doesn't break anything, this would be very helpful.

Note: we're all French speakers in this bug so far.

#11

Updated by Yannick Warnier over 8 years ago

  • Target version set to 1.8.8 stable
#13

Updated by Yannick Warnier about 8 years ago

Andre Boivin wrote:

Ok je vais vérifier mais est-ce que la patch c'est le :
http://code.google.com/p/chamilo/source/detail?r=962fa1c211800202b8e4a71954eb70a3ac77b044&repo=classic

Oui, mais je serais toi, je le testerais plutôt sur http://chamildev.beeznest.com, parce qu'on a fait une série de patches et je ne suis pas certain que celui-ci soit indépendant des autres.

#14

Updated by Andre Boivin about 8 years ago

Sur http://chamilodev.beeznest.com ça ne fonctionne pas, avec plus de 50 hotpotatoes, la flèche qui indique une autre page apparait mais il n'y a rien si je clique sur cette flèche.
Pour voir le résultat, c'est le cours nommé TESTHOTPOT.
Je ne sais pas si c'est un dommage collatéral mais les quiz ne se terminent pas, les scores ne sont donc pas pris en compte.

#15

Updated by Julio Montoya about 8 years ago

Ok I have a commit to send but the repo is read only for now ...

#17

Updated by Andre Boivin about 8 years ago

Super!
Tout semble fonctionner parfaitement pour les hotpotatoes, visibles à plus de 50, les scores sont bien pris en compte ainsi que les prés requis dans les parcours.
Merci et bravo!

#18

Updated by Yannick Warnier about 8 years ago

  • Status changed from Needs more info to Bug resolved
  • Assignee set to Julio Montoya
  • % Done changed from 80 to 100

Merci à toi pour le test! (et à Julio pour le dév, comme d'hab)

Also available in: Atom PDF