Project

General

Profile

Feature #317

Subtitute target="_top" with target="_self"

Added by Carlos Vargas almost 10 years ago. Updated almost 10 years ago.

Status:
Feature implemented
Priority:
Normal
Category:
-
Target version:
Start date:
03/12/2009
Due date:
% Done:

0%

Estimated time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

I'm trying to use dokeos into joomla using "wrapper" function.
It is NOT possible because some target="_top" substitute the joomla window with dokeos.

looking for target="_top" I noticed that they exists only in

index.php
main\forum\forumfunction.inc.php
main\inc\banner.inc.php
main\inc\lib\fileUpload.lib.php
main\inc\lib\main_api.lib.php
main\inc\tool_navigation_menu.inc.php
main\newscorm\learnpath.class.php
main\newscorm\p_header.php
user_portal.php

perhaps also in document.php (accessing to inner directories)

At a first analysis I see that substituing target="_top" with target="_self" Dokeos works OK, except for the exit from Leaning path player.

Some people need (I don't agree very much) the "wrapped navigation", so if it's not necessary target="_top" can be avoided.

History

#1

Updated by Carlos Vargas almost 10 years ago

Actualizado por Furio Petrossi hace 9 meses

Comment

Pleas erase the italian first part : the original is

I'm trying to use dokeos into joomla using "wrapper" function.
It is NOT possible because some target="_top" substitute the joomla window with dokeos.

looking for target="_top" I noticed that they exists only in

index.php
main\forum\forumfunction.inc.php
main\inc\banner.inc.php
main\inc\lib\fileUpload.lib.php
main\inc\lib\main_api.lib.php
main\inc\tool_navigation_menu.inc.php
main\newscorm\learnpath.class.php
main\newscorm\p_header.php
user_portal.php

perhaps also in document.php (accessing to inner directories)

At a first analysis I see that substituing target="_top" with target="_self" Dokeos works OK, except for the exit from Leaning path player.

Some people need (I don't agree very much) the "wrapped navigation", so if it's not necessary target="_top" can be avoided.
#2
Actualizado por Furio Petrossi hace 9 meses

  • Fichero dokeoswrapped.png añadido

Comment

Example of wrapping
#3
Actualizado por Furio Petrossi hace 9 meses

Comment

also showinframes.php need changes using css instead of frames (f.e. see http://tutorials.alsacreations.com/frames/suite.php, but you, programmers, well know the matter! )
#4
Actualizado por Furio Petrossi hace 8 meses

Comment

I see that new Docebo SCORM player uses ajax instead of frames: in general that's better idea.
#5
Actualizado por Yannick Warnier hace 7 meses

Comment

Hi Furio, Dokeos 1.8.6 SVN now uses only one iframe and implements CSS a much better way (although the fullscreen mode has to be fixed tomorrow)
#6
Actualizado por Furio Petrossi hace 7 meses

Comment

Well done, I'll try it, Yannick
#7
Actualizado por Yannick Warnier hace 5 meses

Comment

Any news on this, Furio?
#8
Actualizado por Furio Petrossi hace 5 meses

  • Fichero 2009-07-06_113953.png añadido

Comment

There are less _top target now: the more important are in newscorm player. I don't know if it is a compulsive feature.
The change is necessary for an embedded navigation.
Roberto Sciamanna published an integration between joomla and dokes that need a _self target (as saved in http://www.dokeos.com/forum/viewtopic.php?t=29579 ).
In the attached image there's a list of target="_top" yet presents in Dokeos.
#9
Actualizado por Furio Petrossi hace 5 meses

Comment

Out of topic: in
http://projects.dokeos.com/index.php?do=details&task_id=4356&project=1&order=lastedit&sort=desc
there is a SEVERE bug that is pendig without answer, can you give a look? Thank you.
#10
Actualizado por Yannick Warnier hace 4 meses

Comment

I don't think we can actually replace all "_top" by "_self", because there are case, precisely, where we want a "top" when there is an iframe or a frame... Maybe if we can reduce the number of frames... but this is another task.

I'm assigning Jhon and Ronny on this task, with the specific goal of removing all non-damaging "_top" and replacing them by "_self", but there are cases where this will probably not work...
#11
Actualizado por Jhon Hinojosa hace 4 meses

Comment

SVN#22072 change target="_top" with target="_self" to forum, menu link, tools bar
#12
Actualizado por Ronny Velasquez hace 4 meses

Comment

SVN#22073 change partial target="_top" with target="_self" to file index.php
#13
Actualizado por Jhon Hinojosa hace 4 meses

Comment

SVN#22074 change target="_top" with target="_self" to document, newscorm
#14
Actualizado por Ronny Velasquez hace 4 meses

Comment

SVN# r22079 change target="_top" with target="_self" to file fileUpload.lib.php, ready to be tested
#15
Actualizado por Julio Montoya hace 3 meses

  • Estado changed from Assigned to Requires testing * Asignado a changed from Jhon Hinojosa to Arthur Portugal * Prioridad changed from Normal to Low * Versión prevista changed from 1.8.6 SVN to 1.8.7

Comment

ping...
#16
Actualizado por Arthur Portugal hace 3 meses

  • Complexity set to Average

Comment

Jhon Hinojosa wrote:

SVN# r22072 change target="_top" with target="_self" to forum, menu link, tools bar

Acabo de probar sobre lo que son enlaces del menu y barra de herramientas, estan bien, pero se encontro bug en la busqueda, tarea relacionada con la DT #5116
#17
Actualizado por Arthur Portugal hace 3 meses

Comment

Arthur Portugal wrote:

Jhon Hinojosa wrote:
SVN#22072 change target="_top" with target="_self" to forum, menu link, tools bar
Acabo de probar sobre lo que son enlaces del menu y barra de herramientas, estan bien, pero se encontro bug en la busqueda, tarea relacionada con la DT #5116

#18
Actualizado por Arthur Portugal hace 3 meses

Comment

Ronny Velasquez wrote:

SVN#22073 change partial target="_top" with target="_self" to file index.php

I did the test and its ok.
#19
Actualizado por Arthur Portugal hace 3 meses

Comment

Ronny Velasquez wrote:

SVN#22079 change target="_top" with target="_self" to file fileUpload.lib.php, ready to be tested

I did the test and its ok.
#20
Actualizado por Arthur Portugal hace 3 meses

  • Estado changed from Requires testing to Solved * % Realizado changed from 10 to 100
#2

Updated by Carlos Vargas almost 10 years ago

  • Status changed from New to Feature implemented

Also available in: Atom PDF