Chamilo LCMS Connect » Core » Admin

I can't seem to reproduce the problem, but remember having it myself... I've added some registration checks in the user_data_manager so the error should be avoided if it ever turned up again... the only thing that can happen is the checks won't work or the use statements fail if the files are actually missing because of the use of constans for application name etc.

I don't think this can be marked as resolved.
there is still code from an optional application being executed in the core.
although it does not throw an error since a check is added, this doesn't mean it is really resolved

/** * Checks whether the user is allowed to be deleted * Unfinished.
*/
static function user_deletion_allowed($user) {
//A check to not delete a user when he's an active teacher
// Weblcms is an optional application, so first check if the app is installed:
$weblcms_registration = AdminDataManager :: get_registration(WeblcmsManager :: APPLICATION_NAME);
if($weblcms_registration) {
// if active
if($weblcms_registration->get_status() == Registration :: STATUS_ACTIVE) {
$courses = WeblcmsDataManager :: get_instance()->count_courses(new EqualityCondition(Course :: PROPERTY_TITULAR, $user->get_id()));
if ($courses > 0) {
return false;
}
}
}
return true;
}

I don't see any way to do this check otherwise at the moment. You should not be allowed to delete the user if he is an active teacher, making the weblcms responsible for removing all linked data on removal is in my opinion unacceptable, because important data could be removed, and the other way around, preventing the user app from removing, is, well, just as it states now, responsibility of the core.

Maybe some generic system should be implemented that asks all installed apps if the operation should be performed, this way each application can do some checks and possibly prevent the deletion. But since we are trying to get something stable and this is a major refactoring it might not be a bad idea to leave this "resolved" for the time being, and change the tracker to refactoring (in a later release with a generic system for making those checks in all apps).

Any other remarks?

Resolved