Project

General

Profile

Bug #3069

Internally made html & text encoding

Added by Marko Kastelic over 8 years ago. Updated almost 7 years ago.

Status:
Bug resolved
Priority:
Normal
Category:
-
Target version:
Start date:
10/03/2011
Due date:
% Done:

100%

Estimated time:
Spent time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

when document (html) is created with internal html editor, produced html is not supplied with charset info. If this document is used inside the iframe, the shown encoding is correct (inherited from document with the iframe?), but fullscreen (without the frame) shows only by browser detected or by web browser forced encoding(s). Is it possible to add suitable meta tag in the head section of produced document ?

Associated revisions

Revision 0a3a8663 (diff)
Added by Julio Montoya about 7 years ago

Removing unnecessary js/css code in the empty template see #3069

History

#1

Updated by Ivan Tcholakov over 8 years ago

  • Status changed from New to Assigned
  • Assignee set to Ivan Tcholakov
  • Priority changed from Low to Normal
  • Target version set to 1.8.8 beta

Yes, I confirm this bug.

#2

Updated by Julio Montoya over 8 years ago

when creating a new document the default html is this

<html dir="ltr">
    <head>
        <title></title>
    </head>
    <body>
        <p>&nbsp;</p>
    </body>
</html>

We could edit it in order to add the charset information, I think is a bad idea to hack the HTML file every time we read it

#3

Updated by Marko Kastelic over 8 years ago

force changing is not an option. But why not insert charset once, on creation, with course/session language charset ? "create on platform for use with platform". other options could be: utf8 for default, selectable from editor, global setting for document tool where you choose to insert charset info on not)

#4

Updated by Ivan Tcholakov over 8 years ago

I prefer documents on creation to have the same encoding as the system has. Anyway, after Chamilo 1.8.7 the system encoding is UTF-8 by default.

#5

Updated by Yannick Warnier over 8 years ago

  • Subject changed from Internaly made html & text encoding to Internally made html & text encoding
#6

Updated by Yannick Warnier over 8 years ago

I don't think this should be taken care of particularly in 1.8.8.
I agree with Marko that every document that can be opened independently should have a charset information (some web servers are not well configured to avoid this problem, and some web browsers make very bad guesses).
How we do that is still an open issue.

#7

Updated by Yannick Warnier over 8 years ago

  • Target version changed from 1.8.8 beta to 1.8.8.4
#8

Updated by Ivan Tcholakov over 8 years ago

14332:6d2c8fccbc16 Bug 3069: Adding character set information to the empty template.
https://code.google.com/p/chamilo/source/detail?r=6d2c8fccbc165389299cd6d7d131a584f3dadd8f&repo=classic

Unfortunately the editor does not preserve character data on Opera 11.01 and Firefox 4, try the button "Source" several times. On Explorer 8 testing is ok.

#9

Updated by Yannick Warnier over 8 years ago

That was quick. OK, I think this pretty much closes the bug, even if FF4 and Opera don't get it (they probably consider now that they can detect the encoding, or maybe there is a new convention for this...?)
Or maybe they use exclusively the HTTP headers (which in this case would also be ok and comes back to what you were saying, Ivan)

#10

Updated by Ivan Tcholakov over 8 years ago

  • % Done changed from 0 to 10

About Opera and Firefox: I described a different javascript bug, that erases the encoding data within the edited html. It seems to me that the FCKEditor is getting old.

There are more (PHP) changes to be done about setting encoding for the other, non-empty templates, I will do this later.

#11

Updated by Yannick Warnier about 8 years ago

  • Status changed from Assigned to New
  • Assignee deleted (Ivan Tcholakov)
  • Target version changed from 1.8.8.4 to 1.9 Stable
#12

Updated by Yannick Warnier over 7 years ago

  • Target version changed from 1.9 Stable to 1.9.2
#13

Updated by Yannick Warnier about 7 years ago

  • Target version changed from 1.9.2 to 1.9.4
#14

Updated by Julio Montoya about 7 years ago

  • Status changed from New to Needs more info
  • % Done changed from 10 to 80

Removing unnecessary js and css code when loading an empty template + adding charset in the HTML5 format

#15

Updated by Yannick Warnier almost 7 years ago

  • Status changed from Needs more info to Bug resolved
  • Assignee set to Ivan Tcholakov
  • % Done changed from 80 to 100

I think we're good. The charset is now added. We should extend the HTML header a bit, but I think that would be redundant with possible later efforts to migrate to CKeditor.

Also available in: Atom PDF