Project

General

Profile

Bug #3041

link: url must start with protocol

Added by Laurent Opprecht over 8 years ago. Updated over 8 years ago.

Status:
Bug resolved
Priority:
Normal
Assignee:
-
Target version:
Start date:
04/03/2011
Due date:
20/05/2011
% Done:

100%

Estimated time:
Complexity:
Normal

Description

Create a link.
For example www.google.com.
Save it
View it.
Click on link.
It fails because href = /chamilo/www.google.com. I.e. it must start with http/https.
Many people are not so inclined to enter the protocol. Most people will use external urls.

Possible solutions:

  • Would be better to say url starting with / relates to chamilo while others are external. In this case, if protocol is not available default to http://.

or

  • Provide some UI feedback that a url is inernal/external to avoid issues.

History

#1

Updated by Stefaan Vanbillemont over 8 years ago

  • Project changed from Chamilo LCMS Connect to Repository
  • Category deleted (4)
#2

Updated by Stefaan Vanbillemont over 8 years ago

  • Target version set to 2.1.0
#3

Updated by Anonymous over 8 years ago

  • Due date set to 19/05/2011
  • Status changed from New to Assigned
  • Assignee set to Anonymous
#4

Updated by Anonymous over 8 years ago

  • Status changed from Assigned to Needs more info

When I take a look at the current dev code, the link content object has the http:// preset in the inputfield.
Is this enough GUI feedback to get this issue closed?

#5

Updated by Laurent Opprecht over 8 years ago

This is an improvement yes.
I would say a slighlty better scheme would be:

if url starts with / then it is relative to the current application.
if not and no protocol exists prepend the http. That is if the string does not start with **://

as many people like to enter the url without the protocol

#6

Updated by Anonymous over 8 years ago

  • Due date changed from 19/05/2011 to 20/05/2011
  • Status changed from Needs more info to Assigned

I will take a deeper look inside the code and will add the fix you mentioned.

#7

Updated by Anonymous over 8 years ago

  • Status changed from Assigned to Needs testing
  • % Done changed from 0 to 100

implemented the check on dev

#8

Updated by Michael Hosdez over 8 years ago

  • Status changed from Needs testing to Bug resolved

Also available in: Atom PDF