Chamilo LCMS Connect » Core » Common

To refactor the API itself I think it's important that no MDB2 objects leak out so as to make the abstraction complete. That means anything returning MDB2 objects should either be marked protected/private (since those can only be helper methods) or wrapped in Chamilo-specific classes.

This would also make it easier to move to PDO or some other abstraction layer when MDB2 finally dies.

Please keep in mind that PDO in and of itself is not an abstraction layer in the same way MDB2 is.

delete() and delete_objects() are identical. One should be removed, or they should be differentiated somehow.

Goulwen Reboux wrote:

When starting digging in the code, I got lots of warnings from MDB2 about Strict Standards when calling non static methods statically. I've done a patch, but I'm not sure it's OK to change this in Chamilo, as it's more the responsability of MDB2, but in the other hand, MDB2 activity is pretty low now. At least it allows to develop with default error reporting without having lots of message in the top of the page.

First off, this is unrelated to the issue at hand; this should probably be a separate issue.

But more to the point, I ran into the same issue while writing tests for the Database class, and actually had to hack a workaround into the tests to temporarily disable the strict checking so the tests didn't fail prematurely on those issues, so I think fixing this is rather important. Your patch looks good to me and I think you should commit this, after filing a bugreport with this patch on the MDB2 issue tracker. Then you can refer to your MDB2 ticket number (and/or bugtracker URL) in the commit message.

My tests should help you to find these problems more easily, but unfortunately I still haven't been able to commit that because it's part of my Postgres support changes. I can't commit those until the new stable/dev different repos are set up, which should be by the end of this week I hear.

Yep sorry, I've started write a new issue, but before post it, I made a new research for "MDB2" and found the ticket. I assume wrongly that it's related.

I create a new ticket on MDB2 issue tracker and then will add a new ticket here with the patch (I don't have the commit access currently)