Chamilo LMS

It filters by the users that receive the message not by the sender. It works when I test it.
We should change the label to "Filter by sender" or "Filter by destination user"

Seems like we lost completely the ability to filter events by anything else than a date now.
Olivier, could you update us (with a screenshot, maybe) about the filtering options that you need? Moving this to 1.9.2 at least.

OK, refreshing this task now.

There should be an option for the admin to filter by destination user or destination group inside the course agenda tool.
The generic tool possibly includes too many events to be able to filter by user or group, but the course tool should offer a select list saying "Filter by destination:" and give a list of groups and users, just left of the "Import iCal" icon.

Just like the one you get when creating an event: main/calendar/agenda.php?cidReq=ABC&id_session=0&gidReq=0&sort=asc&toolgroup=0&action=add

Upload These are the changes for filter. I have a question it should be necessary to filter by groups? These filter by user

Waiting for the release of 1.9.4 in order to send this changes

I found many problems with your changes please be careful next time:

You can put your js code inside the "$(document).ready()" or "$(function()" both jquery functions are the same (function() is a shorcut of ready).

In the construct_to_select_form() be very careful with HTML tags, you did this:

function construct_to_select_form($group_list = null, $user_list = null, $filter = 0)
{
    $result = '<form style="float:right;"><select data-placeholder="'.get_lang('Select').'name="sel_to" class="chzn-select" id="selected_form_id"></form>';

    // adding the groups to the select form
    $result .= '<option value=0>'.get_lang('Everyone').'</option>';
    // adding the individual users to the select form
    if (!empty($user_list)) {
        $result .= '<optgroup label="'.get_lang('Users').'">';
        foreach ($user_list as $this_user) {
            $username = api_htmlentities(sprintf(get_lang('LoginX'), $this_user['username']), ENT_QUOTES);
            $user_info = api_get_person_name($this_user['firstname'], $this_user['lastname']).' ('.$this_user['username'].')';
            $selected = $this_user['user_id'] == $filter ? "selected" : null;
            $result .= "<option  title='$username' value=".$this_user['user_id']." ".$selected.">$user_info.</option>";
        }
        $result .= "</optgroup>";
    }
    $result .= "</select>";
    return $result;
}

You forgot to close the "data-placeholder" attribute and the "</form>" tag should be at the end of the form.

You should try to use the UI of bootstrap instead of recreating a new interface like adding a <div style="width:380px;"> you could use <form class"form-search">
You can check those divs here:

http://twitter.github.com/bootstrap/base-css.html#forms
I sent my changes here:

http://code.google.com/p/chamilo/source/detail?r=6cbea405639a6a03e4881972179a945411a80dd1&name=1.9.x&repo=classic

Don't forget to add intval() when you get a variable from the user($_POST, $_GET, $_REQUEST) and also is more clear to declared a variable with "$user_id" instead of "$sel_user" in French "sel" is "salt", so is funny to read "sel user" :)

http://code.google.com/p/chamilo/source/detail?r=281ca82e2ad12244eb41dbd460c198bb47af499c&name=1.9.x&repo=classic

I found a bug: when I select a user I can create an event to other users:

so after adding a message to another user the calendar is updated but it has the user filter so I see nothing. I have to select Everyone then I will see my event.

The solution i have found is to update the filter to the user which is the receiver of the new event created once the dialog is closed. Like this What do you think?

now, url are fixed,and i have added group filter function. Tell me when you upload the files, because it needs testing

Other corrections sent

Julio, did you send these in the end? You didn't say. I sure does seem like there is a difference between the files sent by Yoselyn and the current ones, but I'm not sure if nobody else has worked on these since then...

Yoselyn, please check that the Github repository contains your changes. Otherwise send them now (make sure you don't overwrite any other, unrelated, code when you do that).

I added some comments there

Sorry the file is not the latest, checking...

The correct pull request has been sent:
https://github.com/chamilo/chamilo-lms/pull/42
Please, check it as soon as possible, locally this filter works ok

• lower the box a little - so far it is just a bit above the top border of the icons, in Firefox. I tested with a margin-top in the "action .form {" of base.css and it looks better. Check in Chrome and send to git.
• the texts shown in the dropbox are not helping to understand that it is a filter. Instead of (in Spanish) "Todos", "Grupos" and "Usuarios", it should say "Filtro: Todos", "Filtrar por grupo" and "Filtrar por usuario".

• $FilterAll = "Filter: Everyone";
• $FilterByGroup = "Filter by group";
• $FilterByUser = "Filter by user";

OK for me