Project

General

Profile

Feature #1845

Incoherency in links list.

Added by Olivier CORRE about 9 years ago. Updated over 7 years ago.

Status:
Feature implemented
Priority:
Normal
Category:
-
Target version:
Start date:
08/08/2010
Due date:
% Done:

100%

Estimated time:
Spent time:
Complexity:
Easy
SCRUM pts - complexity:
3

Description

In order to be able to configure a link to open in a new window, one has to enable the link to display on the course/exercice page. i find this quite incoherent and confusing! Opening a link makes a student leave the platform... Shouldn't the option to choose between _self and _blank be on by default?


Files

link.php (19.1 KB) link.php Yoselyn Castillo, 06/06/2012 20:07

History

#1

Updated by Yannick Warnier over 7 years ago

  • Target version set to 1.9 Beta
#2

Updated by Yannick Warnier over 7 years ago

  • Complexity changed from Normal to Easy
  • SCRUM pts - complexity changed from ? to 3
#3

Updated by Yannick Warnier over 7 years ago

  • Status changed from New to Assigned
  • Assignee set to Yoselyn Castillo
#4

Updated by Yannick Warnier over 7 years ago

Julio already fixed this in http://code.google.com/p/chamilo/source/detail?r=3ece3bd05622b5ee4aa94d92c4bf41ebded5386e&repo=classic&path=/main/inc/lib/link.lib.php
Please only check that the links can be set to open in a new window, both in the course homepage and in the links tool page.

Olivier, why did you mention "exercises"? We don't get that... help!

#5

Updated by Olivier CORRE over 7 years ago

Olivier, why did you mention "exercises"? We don't get that... help!

What i meant is that the link has to be displayed on a course page in order to open in _blank.

I can access the Chamilo test platform but I can't login onto it for some unknown reason so I can't test. Sorry about that.

#6

Updated by Yannick Warnier over 7 years ago

We reinstalled it recently so your account may have been removed. Please use admin/admin to login

#7

Updated by Yoselyn Castillo over 7 years ago

  • File link.php link.php added
  • Assignee changed from Yoselyn Castillo to Julio Montoya
  • % Done changed from 0 to 90

Sube este fichero, es para ponerle lo que pidio Olivier de poner por defecto que se abran en _self.

#8

Updated by Olivier CORRE over 7 years ago

I just tried on http://chamilodev.beeznest.com, seems to be fixed. Both _self and _blank work properly now.

#9

Updated by Yannick Warnier over 7 years ago

Great, but strange (Yoselyn's patch hasn't been applied yet). I'll let Julio check that. Long live the Chamilo community, working literally "around-the-clock" :-)

#10

Updated by Olivier CORRE over 7 years ago

it is a pre 1.8.8.4 bug (date from 2 years back), it seems to be already fixed in latest version.

#11

Updated by Yannick Warnier over 7 years ago

  • Status changed from Assigned to Needs more info
  • Assignee changed from Julio Montoya to Yoselyn Castillo

Yoselyn, podrías explicar tu cambio por favor (por ejemplo a través de comentarios aquí o dentro del código)? No entiendo en que cambiar el $target_link a _self soluciona el problema... (por lo menos revisando rápido, parece que la variable $target_link tiene más que ver con la página de destino que con la manera en la cual se abre).

#12

Updated by Yoselyn Castillo over 7 years ago

El cambio solo hice porque pense que Olivier decia que era mejor que estuviera _self on por defecto para que el estudiante no tuviera que salir de la ventana,pero tanto _self como _blank abren correctamente.

#13

Updated by Olivier CORRE over 7 years ago

I would suggest not to change anything since it seems to be already fixed in 1.8.8.4.

#14

Updated by Yannick Warnier over 7 years ago

  • Status changed from Needs more info to Feature implemented
  • % Done changed from 90 to 100

OK, let's leave it this way then. Sorry Yoselyn, my fault.

Also available in: Atom PDF