Project

General

Profile

Bug #1713

Duplicate Query in Update db 1.8.6.2 to 1.8.7

Added by Omar Arino over 9 years ago. Updated over 9 years ago.

Status:
Feature implemented
Priority:
Normal
Category:
-
Target version:
Start date:
10/07/2010
Due date:
% Done:

100%

Estimated time:
Complexity:
Normal
SCRUM pts - complexity:
?

Description

In file /main/install/update-db-18.6.2-1.8.7.inc.php line 424 and 425 say:

$query = Database::query("ALTER TABLE `".$table."` CONVERT TO CHARACTER SET utf8 COLLATE utf8_general_ci;");
$res = Database::query($query);

This 2 lines send 2 querys, the first line send and SQL sentence and de second line send TRUE or FALSE (result of the first query). And send an error to log file.

I think it may say:

$query = "ALTER TABLE `".$table."` CONVERT TO CHARACTER SET utf8 COLLATE utf8_general_ci;";
$res = Database::query($query);

Related issues

Related to Chamilo LMS - Feature #272: UTF-8 native supportFeature implemented03/12/2009

Actions

History

#1

Updated by Ivan Tcholakov over 9 years ago

  • Status changed from New to Assigned
  • Assignee set to Ivan Tcholakov
  • Target version set to 1.8.7.1

It is my error entered on #272 implementation with the transaction http://code.google.com/p/chamilo/source/detail?r=bdd1356f578fd30dd591098e6a298b49ee6a4ba4&repo=classic

This error is copy/pasted several times and it occurs at the following lines:
105, 106
111, 112
271, 272
277, 278
351, 352
357, 358
424, 425 (reported)

This bug causes unwanted lines in the error log, indeed.

I am taking this task. Omar, you suggestion is to be implemented, thank you for this report.

#2

Updated by Ivan Tcholakov over 9 years ago

  • Status changed from Assigned to Feature implemented
  • % Done changed from 0 to 100

12068:034e3530b78d Bug #1713 - Duplicate query calls removal from .../install/update-db-18.6.2-1.8.7.inc.php. The bug has been reported (with solution given) by Omar Arino.
http://code.google.com/p/chamilo/source/detail?r=034e3530b78d228b891b6d14c0d90430dd14da68&repo=classic

Thank you once again.

Also available in: Atom PDF