Chamilo LMS

I have a question. I wonder, why the object variable olms is to eliminated? Is this change mandatory for solving the problem?

As I understand, olms is used like a namespace, where all the related variables are hidden. If we remove the variable olms, then all that was inside will move to the global namespace. There variables with very simple names will appear: score, min, max, ... Collisions with other javascripts might happen.

This is the only solution I found.
The problem with HotPotatoes is probably related to these variables.
Currently, I have no experience other problems with these changes.
André

Thank you, I saw the additional information http://www.chamilo.org/fr/node/600
Ivan.

http://www.chamilo.org/en/node/595

apparently the result is sent back from exercice_result.php, line 1083, to scorm_api.php's API.void_save_asset(), which then calls xajax_save_item() and apparently the call gets routed to lp_ajax_save_itemp.php correctly...

scorm_api.php 1034-1047

/**
 * Save a Dokeos learnpath item's time and mark as completed upon leaving it.
 * Same function as lms_save_asset() but saves it with empty params
 * to use values set from another side in the database. Only used by Dokeos quizzes.
 * Also save the score locally because it hasn't been done through SetValue().
 * Saving the status will be dealt with by the XAJAX function.
 */
function dokeos_void_save_asset(myscore,mymax)
{
    logit_lms('lms_save_asset',2);
    olms.score = myscore;
    if((mymax == null) || (mymax == '')){mymax = 100;} //assume a default of 100, otherwise the score will not get saved (see lpi->set_score())
    xajax_save_item(olms.lms_lp_id, olms.lms_user_id, olms.lms_view_id, olms.lms_item_id, myscore, mymax);
}

Here the status is not passed for recording. See the comment "Saving the status will be dealt with by the XAJAX function."

Saving HotPotatoes scores works on 1.8.5. On 1.8.6 and so forth saving scores fails.

Thx. This is the last bug for 1.8.7.1 and I'm retaking work on it now. As far as I see it, there might be problems due to the parameters actually passed to lp_ajax_save_item():

In save_item(3,4,1,16,100,100,undefined,"undefined",undefined,"undefined","undefined","","undefined"), referer: /main/newscorm/lp_controller.php?cidReq=VVV&action=view&lp_id=3

With the changes, everything works fine on my side, again you have solved a problem that required a prerequisite after a HotPotatoes if it was never marked as complete.
Finally an integrated solution for HotPotatoes.
Thank you and congratulations to the team!