Project

General

Profile

Bug #1303

Translation: French: visible/invisible in session creation dropdown

Added by Yannick Warnier over 9 years ago. Updated over 9 years ago.

Status:
Feature implemented
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
18/05/2010
Due date:
% Done:

40%

Estimated time:
Complexity:
Normal
SCRUM pts - complexity:
0.5

Description

Should be "Accessible"


Files

session_visible_invisible.png (9.58 KB) session_visible_invisible.png anna frolova, 19/05/2010 15:19

History

#1

Updated by anna frolova over 9 years ago

  • File trad4all.inc.php added

Yannick,

I edited the trad4all.inc.php file

I didn't find how to upload the new files in repository (once again, you'll need to explain me...), I send it here as attached file

line 45
$lang_show_hide = "Visible/invisible";

changed to

$lang_show_hide = "Accessible/Inaccessible";

#2

Updated by anna frolova over 9 years ago

  • Status changed from New to Needs more info
  • Assignee changed from anna frolova to Yannick Warnier
#3

Updated by anna frolova over 9 years ago

  • File deleted (trad4all.inc.php)
#4

Updated by anna frolova over 9 years ago

ok, Yannick,

let's do as if my previous message didn't exist. I understood that I was wrong. Now I need that someone approves the way I imagined to solve the "issue".

1. in the files main/admin/session_add.php and main/admin/session_edit.php I see references to the language file:

session_add.php
line 374

$visibility_list = array(SESSION_VISIBLE_READ_ONLY=>get_lang('ReadOnly'), SESSION_VISIBLE=>get_lang('Visible'), SESSION_INVISIBLE=>api_ucfirst(get_lang('Invisible')));

so we need 3 variables: 'ReadOnly', 'Visible', 'Invisible'

2. in the trad4all.inc.php I found the 3 variables:

line 17: $langVisible = "Visible";
line 105: $langInvisible = "Rendre invisible";
line 751: $ReadOnly = "Lecture seule";

by the way the value "Visible/invisible" corresponds to $lang_show_hide (line 45)

What I'd logically need to do is to edit the variables in he following way:

line 17: $langVisible = "Accessible";

and leave the 2 variables as such:

line 105: $langInvisible = "Rendre invisible";
line 751: $ReadOnly = "Lecture seule";

Am I right?
If it is so, I'll edit it in 2 seconds.

BUT what I don't understand is how the session_add and session_edit FINDS the "visible/invisible" value...
So I'm not sure that I understand well how it works.

Sorry, a "piece of cake" task became a big issue when I tried to solve it :)

#5

Updated by Julio Montoya over 9 years ago

  • % Done changed from 0 to 40

Is not possible to change these, since there are other tools that may used that variable (calendar, documents, etc)
line 17: $langVisible = "Accessible";

What we could do is create special variables for this tool:
$SessionVisible = Accessible
$SessionInvisible = Rendre invisible

Read only could be the same
$ReadOnly = "Lecture seule";

And of course change the code in sessions...

#6

Updated by Yannick Warnier over 9 years ago

Julio Montoya wrote:

Is not possible to change these, since there are other tools that may used that variable (calendar, documents, etc)
line 17: $langVisible = "Accessible";

What we could do is create special variables for this tool:
$SessionVisible = Accessible
$SessionInvisible = Rendre invisible

Read only could be the same
$ReadOnly = "Lecture seule";

And of course change the code in sessions...

Well, in fact there are two opposite problems in your suggestion:
1. "SessionVisible" doesn't have sense if what you mean is "accessible"
2. "Accessible" doesn't have sense if you are going to call the opposite "Rendre invisible"

Please do the following instead:
  • Create variables $SessionAccessible = "Accessible"; $SessionNotAccessible = "Non accessible"; $SessionReadOnly = "Accessible en lecture seule":

Sorry Anna, I just didn't find the time to coach you this time. Will do better, in time for the next version.

#7

Updated by Yannick Warnier over 9 years ago

  • Status changed from Needs more info to Assigned
  • Assignee changed from Yannick Warnier to Julio Montoya
#8

Updated by Julio Montoya over 9 years ago

Variables added to translation.chamilo.org

$SessionAccessible = "Accessible"; $SessionNotAccessible = "Non accessible"; $SessionReadOnly = "Accessible en lecture seule":

http://code.google.com/p/chamilo/source/detail?r=374532069e776171edd1fd8a9bf96c7f9a6ed8ce&repo=classic

Yannick Warnier wrote:

Julio Montoya wrote:

Is not possible to change these, since there are other tools that may used that variable (calendar, documents, etc)
line 17: $langVisible = "Accessible";

What we could do is create special variables for this tool:
$SessionVisible = Accessible
$SessionInvisible = Rendre invisible

Read only could be the same
$ReadOnly = "Lecture seule";

And of course change the code in sessions...

Well, in fact there are two opposite problems in your suggestion:
1. "SessionVisible" doesn't have sense if what you mean is "accessible"
2. "Accessible" doesn't have sense if you are going to call the opposite "Rendre invisible"

Please do the following instead:
  • Create variables $SessionAccessible = "Accessible"; $SessionNotAccessible = "Non accessible"; $SessionReadOnly = "Accessible en lecture seule":

Sorry Anna, I just didn't find the time to coach you this time. Will do better, in time for the next version.

#9

Updated by Yannick Warnier over 9 years ago

  • Status changed from Assigned to Feature implemented

Also available in: Atom PDF