Project

General

Profile

Feature #1210

Assignement : weird behaviour of document display

Added by Hubert Borderiou about 9 years ago. Updated almost 8 years ago.

Status:
Bug resolved
Priority:
Normal
Category:
-
Target version:
Start date:
03/05/2010
Due date:
% Done:

100%

Estimated time:
3.00 h
Spent time:
Complexity:
Normal
SCRUM pts - complexity:
3

Description

Hi,

I had several feedbacks of teachers concerning the Assignment tool.
They do not understand the way this tool function.
When student can see there job ? What is the effect of the eye ? It does not function the same way if you are in a folder or not.
(or if your folder had been created on a previous version of Dokeos)

See attached for the report of how visibility functions for document on the root folder, or on subfolders.

I've modifiy the function of this tool, to have the same functions for the root assignement folder, and for sub-folders (except for Qualification and marks). I've added 2 checkboxes :
[ ] Owner of an assigment will always see his document, even if the 'eye' icon is closed.
[ ] Display assignment scoring to students ? (need to be in a folder created in the tool Assignment.)

You can see how it works now on this screencast (in French) : http://opus.grenet.fr/dokeos/gu/courses/RESSDSIGU/document/flash/2010-03-22_1703_outil_travaux.swf?cidReq=RESSDSIGU
(for version 1.8.6.1, but I've updated the patch for version 1.8.7a)

See attached the files I've modified to add these options.

I think it should be a good thing to modify the way Assignement works, as done in my patch, to have a more logical functioning for this tool (I've been using it for weeks on version 1.8.6.1., and teachers are ok with it).

Anayway, I have to go on working on this patch to include Group uploaded files on the Group tool Assigmement. Actually, when a user upload a document in the root folder of his Group Assignement Tool, the file appear on the root folder of the Assignement Tool of the course. That's another bug whitch make teacher lost when they use this tool.


A last thing, working on the 1.8.7a's version of this patch, I saw another problem.
It deals with internationalization and the order of firstname and lastname used for languages.
I've modified the name_order_conventions.php file to have this line for french :
'french' => array( 'format' => 'title last_name first_name', 'sort_by' => 'last_name' ),
(last_name then first_name and sort by last_name)
in order to be able to use the select area when I add user to classes (see attached) with list ordered by lastname.

I've modified this order only for french. It's still first_name last_name in english.

As a result, if I log in once with french interface, and once with english interface, the firstname-lastname order for the Author of uploaded assessement files changes.
It's because it is hardcoded in the database : table student_publication , field author. (it doesn't use the ID of the author, but the first+last name or last+firstname, depends on the language choice on the menu of the first page :s)
(See attached)

It's not really annoying, but it made more difficult to work with publication authors on the database... as I have to do for my patch for version 1.8.7.a.

Hope this help,

regards


Files

2010-05-03_0952.png (25.1 KB) 2010-05-03_0952.png How visibility functions for document on the root folder, or on subfolders Hubert Borderiou, 03/05/2010 14:04
assignement_tool_upgrade.zip (37 KB) assignement_tool_upgrade.zip php files Hubert Borderiou, 03/05/2010 14:04
2010-05-03_1352.png (59.3 KB) 2010-05-03_1352.png add user to classes with list ordered by lastname. Hubert Borderiou, 03/05/2010 14:04
2010-05-03_1127_001.png (37.2 KB) 2010-05-03_1127_001.png first+last name or last+firstname ? Hubert Borderiou, 03/05/2010 14:04

History

#1

Updated by Hubert Borderiou about 9 years ago

I've created two account on my test platform if you want to test it.
http://opus.grenet.fr/dokeos/chamilo187a20100419/index.php
login=teacher
passwd=chamilo123
or
login=student
passwd=chamilo123

You're registered on my test course for assigments.

#2

Updated by Hubert Borderiou about 9 years ago

You have to add database entry on the course table for database chamilo_main

ALTER TABLE `course` ADD `owner_doc_visible` TINYINT NOT NULL DEFAULT '1' AFTER `show_score` ;
ALTER TABLE `course` ADD `display_qualification` TINYINT NOT NULL DEFAULT '1' AFTER `owner_doc_visible`;

#3

Updated by anna frolova about 9 years ago

Nice screencast, Hubert.

Could you please send the link to the Chamilo's forum? I could be useful for other Chamilo users/investigators...

#4

Updated by Julio Montoya about 9 years ago

  • % Done changed from 0 to 20

Hi Hubert,

I'm sending a patch that may help you
I fixed the problem that when assignments are available for everybody or just for the teacher.

http://code.google.com/p/chamilo/source/detail?r=c0028f0e9cc8fb0e7f071a8c9d1d90118b87c52a&repo=classic

#5

Updated by Yannick Warnier about 9 years ago

Julio, please also check that a student can always see his own work (yesterday he couldn't see is own work if the option "show works to all students" was not selected), which lead him to misunderstanding if he had sent his work or not (maybe you already fixed it).

Hubert, when reporting a series of problem, please use the subtask feature: define one main task, then define other tasks that are elementary. For example:
  • Task 123 is the main task (this task we are looking at, right now)
  • Task 124 is a sub-task, only giving one problem and how you think it could be fixed. You then come back to task 123 and say it has "Related issues" (demandes liĆ©es) and add 124 with the relation "blocks"
  • Task 125 is another sub-task, only giving one problem and how you think it could be fixed. You then come back to task 123 and do the same about task 125.

It's more work to report, but the lack of enough developers is forcing us to put a little more strain on the reporters, in order to make the work of developers easier. You will see that it all becomes clearer once the task is split into little atomic elements.

The difference is that you will take 30 minutes for the main task + 5 minutes per sub-task (in this case let's say 5 sub-tasks - so 55 minutes in total), while the consequent bug-fixing and communication will at least save a few hours (for example take 30min for each sub-task instead of 5 hours for the whole big bunch). Developers work better if they can focus on one single problem at a time.

Thanks!

#6

Updated by Hubert Borderiou about 9 years ago

Hi,
ok I understand.
I'll report atomic tasks, linked together.
Is the code I attached usefull for you ?
(if you diff it with yours ?)

#7

Updated by Julio Montoya about 9 years ago

  • Target version changed from 1.8.7 RC1 to 1.8.7
#8

Updated by Yannick Warnier about 9 years ago

  • Status changed from New to Assigned
  • Assignee set to Julio Montoya

Hi Hubert,

Didn't check your code personally. I suggest Julio has a look before next Wednesday and see if we integrate something into 1.8.7 or not. When submitting approved patches, we generally add the contributor name to credits.html inside the package, together with his e-mail address. How would you like to figure there?

#9

Updated by Julio Montoya about 9 years ago

Can't modify the database right now... Maybe we can move these for the 1.8.7.1 ?
Did my fix works for you?

#10

Updated by Julio Montoya about 9 years ago

  • Status changed from Assigned to Needs more info
  • Assignee changed from Julio Montoya to Hubert Borderiou
#11

Updated by Yannick Warnier about 9 years ago

  • Target version changed from 1.8.7 to 1.8.7.1

In any case, we are in an emergency situation to be able to release 1.8.7, so I'm moving this to 1.8.7.1

#12

Updated by Yannick Warnier about 9 years ago

  • Target version changed from 1.8.7.1 to 1.8.8 stable
#13

Updated by Yannick Warnier over 8 years ago

  • Target version changed from 1.8.8 stable to 1.8.8.4
  • Estimated time set to 3.00 h
  • SCRUM pts - complexity changed from ? to 3

Postponing again. Hubert, we are waiting feedback in this task too. Julio asked if his patch helped.

#14

Updated by Yannick Warnier almost 8 years ago

  • Status changed from Needs more info to Bug resolved
  • % Done changed from 20 to 100

Closed (no feedback provided by reporter).

Also available in: Atom PDF